Piotr Kliczewski has posted comments on this change. Change subject: v2v: Convert VM from external source to Data Domain ......................................................................
Patch Set 1: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/37509/1/client/vdsClient.py File client/vdsClient.py: Line 1914: def convertVmFromExternalSystem(self, args): Line 1915: if len(args) != 5: Line 1916: raise ValueError('Wrong number of arguments') Line 1917: uri, username, password, vmProperties, jobId = args Line 1918: status = self.s.convertVmFromExternalSystem(uri, username, password, Please consider using getAuthFromArgs for password Line 1919: vmProperties, jobId) Line 1920: if status['status']['code'] == 0: Line 1921: print "v2v job started" Line 1922: return status['status']['code'], status['status']['message'] http://gerrit.ovirt.org/#/c/37509/1/vdsm/rpc/Bridge.py File vdsm/rpc/Bridge.py: Line 405: 'Host_getConnectedStoragePools': {'ret': 'poollist'}, Line 406: 'Host_getDeviceList': {'ret': 'devList'}, Line 407: 'Host_getDevicesVisibility': {'ret': 'visible'}, Line 408: 'Host_getExternalVMs': {'ret': 'vmList'}, Line 409: 'Host_convertVmFromExternalSystem': {}, There is no need to add verb to command_info if there is no return type. Line 410: 'Host_getConvertedVm': {'ret': 'ovf'}, Line 411: 'Host_abortV2VJob': {}, Line 412: 'Host_getHardwareInfo': {'ret': 'info'}, Line 413: 'Host_getLVMVolumeGroups': {'ret': 'vglist'}, Line 407: 'Host_getDevicesVisibility': {'ret': 'visible'}, Line 408: 'Host_getExternalVMs': {'ret': 'vmList'}, Line 409: 'Host_convertVmFromExternalSystem': {}, Line 410: 'Host_getConvertedVm': {'ret': 'ovf'}, Line 411: 'Host_abortV2VJob': {}, As above Line 412: 'Host_getHardwareInfo': {'ret': 'info'}, Line 413: 'Host_getLVMVolumeGroups': {'ret': 'vglist'}, Line 414: 'Host_getRoute': {'ret': 'info'}, Line 415: 'Host_getStats': {'ret': 'info'}, -- To view, visit http://gerrit.ovirt.org/37509 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
