Piotr Kliczewski has posted comments on this change. Change subject: infra: Introduce EventFD support ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/37051/6/lib/vdsm/infra/eventfd/__init__.py File lib/vdsm/infra/eventfd/__init__.py: Line 114: Line 115: def close(self): Line 116: "Closes the fd and clears the internal counter" Line 117: fd = self._fd Line 118: if fd != -1: > This is just as racy as: Done Line 119: self._fd = -1 Line 120: libc.close(fd) Line 121: Line 122: def __del__(self): -- To view, visit https://gerrit.ovirt.org/37051 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6035d4a8dc13ce11cf0425e4945bbf0c19bd92a7 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches