Piotr Kliczewski has posted comments on this change. Change subject: [wip] subscriptions ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/38451/2/lib/yajsonrpc/stompReactor.py File lib/yajsonrpc/stompReactor.py: Line 213: dispatcher.handle_error() Line 214: Line 215: Line 216: class _StompConnection(object): Line 217: log = logging.getLogger("yajsonrpc.StompServer") > you don't use the log.. Done Line 218: Line 219: def __init__(self, server, aclient, sock, reactor): Line 220: self._socket = sock Line 221: self._reactor = reactor Line 241: def get_local_address(self): Line 242: return self._socket.getsockname()[0] Line 243: Line 244: def setMessageHandler(self, msgHandler): Line 245: self._messageHandler = msgHandler > why not to initialize it with None? you'll get attributeError in handleMess Done Line 246: self._dispatcher.handle_read_event() Line 247: Line 248: def handleMessage(self, data): Line 249: if self._messageHandler is not None: -- To view, visit https://gerrit.ovirt.org/38451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1493070f2ba66ca9d39a6661876c82c4727cad62 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
