Francesco Romani has posted comments on this change. Change subject: lib: Add vdsm.concurrent library ......................................................................
Patch Set 2: Code-Review+1 (1 comment) I'm OK to give this code a better spotlight. https://gerrit.ovirt.org/#/c/38464/2/lib/vdsm/concurrent.py File lib/vdsm/concurrent.py: Line 36: # we can only throw one error, and the Line 37: # last one is as good as any. This shouldn't Line 38: # happen. Wrapped methods should not throw Line 39: # exceptions, if this happens it's a bug Line 40: log.error("tmap caught an unexpected error", exc_info=True) I was about to ask about log.exception, but I see this is code move and next patch rewrites this code, so OK with that. Line 41: error[0] = e Line 42: resultsDict[index] = None Line 43: Line 44: threads = [] -- To view, visit https://gerrit.ovirt.org/38464 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee90f4c201293c3df048cc4ad7123a837d236a38 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
