Francesco Romani has posted comments on this change. Change subject: stomp: Optimize stomp encoder\decoder ......................................................................
Patch Set 8: it is hard to review this patch. Most of changes here leave me with a good gut feeling, but it's a leap of faith without proper rationale and possibly some numbers to prove the changes are indeed optimizations. Moreover, I still have the feeling that this patch squashes together too many vaguely related changes. -- To view, visit https://gerrit.ovirt.org/35255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I341e46463e654ae0a086cd49af18aa336b86cb6e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
