Piotr Kliczewski has posted comments on this change. Change subject: API: getVMList: compatibity with internal clients ......................................................................
Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/38805/2//COMMIT_MSG Commit Message: Line 27: With the current 'onlyUUID' defaults, clients of API.py Line 28: will get a list of UUIDs instead of a list of Short Status. Line 29: Line 30: To fix this, and given the findings outlined in the above bullet points, Line 31: we just switch the default value of 'onlyUUID' to cover this use case. How this switch will work with engine 3.5.0? When you set it to False it will get a map which would break the engine (ClassCastException) which results with lost connection to a host. I do not see in this patch how you want mitigate this issue. Line 32: Line 33: Change-Id: I0560a262329f729716577b28aa78b177f0929121 -- To view, visit https://gerrit.ovirt.org/38805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0560a262329f729716577b28aa78b177f0929121 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
