Dan Kenigsberg has posted comments on this change. Change subject: network: models: tag non-VDSM devices used by VDSM ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/38771/1/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 2212: BOOTPROTO=static Line 2213: NM_CONTROLLED=no Line 2214: HOTPLUG=no""" % (BONDING_NAME, VLAN_ID)) Line 2215: Line 2216: rc, _, _ = execCmd([EXT_IFUP, BONDING_NAME]) > might be worthwhile to check that those commands succeeded so the test won' +1, but this must be done on the master branch first. Line 2217: rc, _, _ = execCmd([EXT_IFUP, BONDING_NAME + '.' + VLAN_ID]) Line 2218: Line 2219: status, msg = self.vdsm_net.setupNetworks( Line 2220: {NETWORK_NAME: {'bonding': BONDING_NAME, 'bridged': True, -- To view, visit https://gerrit.ovirt.org/38771 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d3ed2b45d618d404bb340100ca07bc57b2f1136 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <toni+ov...@midokura.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
