Dan Kenigsberg has submitted this change and it was merged. Change subject: API: onlyUUID should affect only short status ......................................................................
API: onlyUUID should affect only short status this patch makes the 'onlyUUID' parameter take effect only if 'fullStatus' equals False (short status was asked). depending on 'fullStatus' boolean parameter, the getVMList API can return either full or short VM status. Due to a bug originally introduced before 3.5.0, short status was incorrectly produced as list(UUIDs), but it is meant to be a list(dict(vmId:UUID, status:vmStatus), ) The 'onlyUUID' parameter was added to preserve backward compatibility with early Engines 3.5.x, but it is meant to fix short status (fullStatus=False), and should not always affect output. Instead, the current code always produces short and broken status if 'onlyUUID' equals True, with the side effect that also fullStatus is affected. Bug-Url: https://bugzilla.redhat.com/1196327 Related-To: https://bugzilla.redhat.com/1196735 Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Signed-off-by: Francesco Romani <from...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/38679 Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M vdsm/API.py M vdsm/rpc/Bridge.py M vdsm/rpc/vdsmapi-schema.json 3 files changed, 8 insertions(+), 5 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
