Nir Soffer has posted comments on this change. Change subject: storage: Add multipath-resize command line tool ......................................................................
Patch Set 7: -Verified (1 comment) Positive flow verified, but need to check if multipathd do fail with non-zero exit code. https://gerrit.ovirt.org/#/c/38467/7/vdsm/storage/multipath-resize File vdsm/storage/multipath-resize: Line 146: log.debug("Resizing map %s", name) Line 147: cmd = [MULTIPATHD.cmd, "-kresize map %s" % name] Line 148: start = utils.monotonic_time() Line 149: rc, out, err = utils.execCmd(cmd, raw=True, execCmdLogger=log) Line 150: if rc != 0: Reminder: we have seen (but could not reproduce) case where multipath exit with zero exit code, but write to stdout or stderr "fail". Need to check if "multipathd -kcommand" is reporting errors using exit code or through stdout/err. Line 151: raise Error("Resizing map %s failed: %s" % (name, err)) Line 152: elapsed = utils.monotonic_time() - start Line 153: log.debug("Resized map %s in %.2f seconds", name, elapsed) Line 154: -- To view, visit https://gerrit.ovirt.org/38467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I229ef55555fa757989329939a9267041785f2c0f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Darshan N <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Fred Rolland <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
