Dan Kenigsberg has posted comments on this change. Change subject: gluster: fix build error in F20 due to blivet version issue ......................................................................
Patch Set 1: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/38942/1/vdsm/gluster/storagedev.py File vdsm/gluster/storagedev.py: Line 24: Line 25: import blivet Line 26: import blivet.formats Line 27: import blivet.formats.fs Line 28: import blivet.size as size from blivet import size is more succinct. But personally, I prefer being reminded that it's a blivet.size Line 29: from blivet.devices import LVMVolumeGroupDevice Line 30: from blivet.devices import LVMThinPoolDevice Line 31: from blivet.devices import LVMLogicalVolumeDevice Line 32: from blivet.devices import LVMThinLogicalVolumeDevice -- To view, visit https://gerrit.ovirt.org/38942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir <tjeya...@redhat.com> Gerrit-Reviewer: Bala.FA <barum...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
