Ramesh N has posted comments on this change. Change subject: gluster: fix build error in F20 due to blivet version issue ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/38942/3/vdsm/gluster/storagedev.py File vdsm/gluster/storagedev.py: Line 181: if isinstance(vg.size, size.Size): : poolMetaDataSize = size.Size('%d KiB' % poolMetaDataSize) : poolDataSize = size.Size('%d KiB' % poolDataSize) : else: : poolMetaDataSize = poolMetaDataSize / 1024.0 : poolDataSize = poolDataSize / 1024.0 Do this logic in the caller itself as its done for createVg to make it more readable. Line 255: if isinstance(deviceList[0].size, size.Size): This check result can be extracted to a variable like 'sizeSupported' and can be reused in other places. -- To view, visit https://gerrit.ovirt.org/38942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir <tjeya...@redhat.com> Gerrit-Reviewer: Bala.FA <barum...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
