Francesco Romani has posted comments on this change.

Change subject: vm: run before_vm_create hook only in the VM boot
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/34530/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2236:             self._dom = NotifyingVirDomain(
Line 2237:                 self._connection.lookupByUUIDString(self.id),
Line 2238:                 self._timeoutExperienced)
Line 2239:         else:
Line 2240:             domxml = hooks.before_vm_start(self._buildDomainXML(), 
self.conf)
restore the missing comment
Line 2241:             self.log.debug(domxml)
Line 2242: 
Line 2243:             flags = libvirt.VIR_DOMAIN_NONE
Line 2244:             if 'launchPaused' in self.conf:


-- 
To view, visit https://gerrit.ovirt.org/34530
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad05e39029acc7b898c7b2af2141bba1d7d3c8e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to