Francesco Romani has posted comments on this change. Change subject: clientIF: avoid automatic start in __init__ ......................................................................
Patch Set 4: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/36895/4/vdsm/clientIF.py File vdsm/clientIF.py: Line 81: self.log = log Line 82: self.vmContainerLock = threading.Lock() Line 83: self.vmContainer = {} Line 84: self._networkSemaphore = threading.Semaphore() Line 85: self._shutdownSemaphore = threading.Semaphore() it is really needed? Line 86: self._recovery = True Line 87: self.channelListener = Listener(self.log) Line 88: self._generationID = str(uuid.uuid4()) Line 89: self.mom = None -- To view, visit https://gerrit.ovirt.org/36895 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1b55e043720cf2e80dc77c6e637f7ddfb0120fb Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
