Nir Soffer has posted comments on this change. Change subject: vm: switch to response.error() ......................................................................
Patch Set 13: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/38268/13/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3563: except Exception: Line 3564: # There is nothing we can do at this point other than logging Line 3565: self.log.exception("Unable to teardown the replication " Line 3566: "destination disk") Line 3567: return response.error('changeDisk') # Finally is evaluated Is the comment relevant now? - remove if not in another patch. Line 3568: else: Line 3569: try: Line 3570: self.cif.teardownVolumePath(diskToTeardown) Line 3571: except Exception: -- To view, visit https://gerrit.ovirt.org/38268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3825faf7a144ef8973dee3cb9f9f0e52fabfc039 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
