Allon Mureinik has posted comments on this change. Change subject: storage: Remove validateStorageServerConnection ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/38230/3/vdsm/dsaversion.py.in File vdsm/dsaversion.py.in: Line 32: version_info = { Line 33: 'version_name': version_name, Line 34: 'software_version': software_version, Line 35: 'software_revision': software_revision, Line 36: 'supportedENGINEs': ['3.3', '3.4', '3.5', '3.6'], > Removing support for engine < 3.3 is different logical change and should b I disagree. There is no agenda to remove older engines - it's an (unfortunate) biproduct of removing this API. Therefore, IMHO, these changes are coupled. Wrt the commit message, it offers the following explanation: """ Since oVirt Engine stopped calling it in 3.3.0, now, in 3.6.0, we can finally remove the call altogether. Note that this patch will make new VDSM versions incompatible with oVirt Engine older than 3.3.0. """ If this is not clear enough, please explain what's lacking, and what kind of explanation you'd want to see there. Line 37: 'supportedProtocols': ['2.2', '2.3'], Line 38: 'clusterLevels': ['3.0', '3.1', '3.2', '3.3', '3.4', '3.5', '3.6'], -- To view, visit https://gerrit.ovirt.org/38230 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c0f3678005c4075098f134a628fef1f3fc8e612 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
