Nir Soffer has posted comments on this change.

Change subject: misc: Support zero-time in getReadDelay()
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/38082/3//COMMIT_MSG
Commit Message:

Line 39: misc.readpeed() changed to parse the returned output.
Line 40: 
Line 41: To verify this change in the engine, I faked dd to return the 
0/Infinity
Line 42: result. Then, verified that VDSInfoReturnForXmlRpc -> mInfo -> > 
storageDomains
Line 43: -> delay gets 0 and the engine don't fail due this value.
We (vdsm) do not care how you tested this in engine, and adding this info in 
the commit message is not helping. It is
enough to claim that you engine is not effected by this change.
Line 44: 
Line 45: Change-Id: I58ae0ec5f3f88a1738ef1b95688534c8c8022362
Line 46: Bug-Url: https://bugzilla.redhat.com/1191549
Line 47: Signed-off-by: Ala Hino <[email protected]>


-- 
To view, visit https://gerrit.ovirt.org/38082
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58ae0ec5f3f88a1738ef1b95688534c8c8022362
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Ala Hino <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Shirly Radco <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to