Dan Kenigsberg has posted comments on this change. Change subject: ppc64: unable to list online logical CPUs ......................................................................
Patch Set 1: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/38983/1//COMMIT_MSG Commit Message: Line 6: Line 7: ppc64: unable to list online logical CPUs Line 8: Line 9: This feature is enabled in VDSM 4.16.7. It is not supported in Line 10: ppc64 architecture. It leads to unsuccessful installation of host. Can you describe the nature of the error? Engine should manage to install Vdsm prior to this feature. Line 11: Line 12: Change-Id: Ia5c4bdbc00217516ba3b7e361ab28e409c507baa Line 13: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1204196 https://gerrit.ovirt.org/#/c/38983/1/vdsm/ppc64HardwareInfo.py File vdsm/ppc64HardwareInfo.py: Line 84: elif key == 'Core(s) per socket': Line 85: corePS = int(value) Line 86: elif key == 'On-line CPU(s) list': Line 87: if value.find(',') == -1 and value.find('-') == -1: Line 88: onlineCpus.append(unicode(value)) what is this unicode() conversion? Do you expect the input to be in utf8? if that the case, use decode(). Please move the parsing of the CPU list to a separate function, which is easier to understand and test. Make sure to add a unit test for it. Line 89: elif value.find(',') == -1: Line 90: cpuindex = cpusets.split('-') Line 91: for cpu in range(int(cpuindex[0]), int(cpuindex[1])+1): Line 92: onlineCpus.append(unicode(cpu)) -- To view, visit https://gerrit.ovirt.org/38983 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5c4bdbc00217516ba3b7e361ab28e409c507baa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Madhu Pavan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Madhu Pavan <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
