Piotr Kliczewski has posted comments on this change. Change subject: ceph: Initial support for network disk ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/38766/4/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 2541: # Line 2542: # Since: 4.17.0 Line 2543: ## Line 2544: {'type': 'NetworkDiskHostInfo', Line 2545: 'data': {'name': 'str', 'port': 'str', 'transport': 'str'}} > for a future patch: do we want something stricter than 'str' for port and t +1 Line 2546: Line 2547: ## Line 2548: # @VmDiskDevice: Line 2549: # Line 2627: 'apparentsize': 'uint', 'index': 'int', 'name': 'str', Line 2628: 'optional': 'bool', 'shared': 'VmSharedDriveType', Line 2629: 'truesize': 'uint', 'volumeChain': ['VmDiskDeviceVolumeChainEntry'], Line 2630: '*baseVolumeID': 'UUID', '*diskType': 'str', Line 2631: '*hosts': ['NetworkDiskHostInfo'], '*protocol': 'str'}} > Same: do we want to add some new enums here for diskType and protocol? It would be good to adopt/reuse already existing like StorageDomainType. Line 2632: Line 2633: ## Line 2634: # @VmInterfaceDeviceType: Line 2635: # -- To view, visit https://gerrit.ovirt.org/38766 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c5792bb6206a227ee0c2df9490b771a69c0093c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Deepak C Shetty <deepa...@linux.vnet.ibm.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches