Madhu Pavan has posted comments on this change.

Change subject: ppc64: unable to list online logical CPUs
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/38983/3/tests/capsTests.py
File tests/capsTests.py:

Line 90:                         '9', '10', '11', '12', '13', '14', '15']
Line 91:         testPath = os.path.realpath(__file__)
Line 92:         dirName = os.path.split(testPath)[0]
Line 93: 
Line 94:         # Using parseCpus to get cpus list
> I am looking for a more extensive test, with more complex inputs. You don't
I have added few more tests. Please feel free to write back if you expect any 
more changes. Thanks
Line 95:         parseCpus = ppc64HardwareInfo._parse_cpu_list(value)
Line 96:         self.assertEqual(parseCpus, expectedCpus)
Line 97: 
Line 98:         # Using caps_lscpu_ppc64_1_4_4.out to get cpus list


-- 
To view, visit https://gerrit.ovirt.org/38983
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5c4bdbc00217516ba3b7e361ab28e409c507baa
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Madhu Pavan <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Madhu Pavan <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to