Yaniv Bronhaim has posted comments on this change. Change subject: Adding Vdsm cron job check for available packages update ......................................................................
Patch Set 8: (3 comments) https://gerrit.ovirt.org/#/c/38401/8/vdsm/updater-tool File vdsm/updater-tool: Line 46: try: Line 47: import dnf Line 48: dnfSupport = True Line 49: except ImportError: Line 50: dnfSupport = False > If you're uploading another version please keep imports above code Done Line 51: Line 52: Line 53: # UpdaterTool refresh installed packages cache and return list of available Line 54: # updates. pkgProvider can be yum, apt-get, dnf and set on creation Line 107: return self.provider.cleanExpireCache() and \ Line 108: self.provider.cleanRpmDB() Line 109: Line 110: if dnfSupport: Line 111: # WIP > ?? I'll return dnfSupport=False. more reasonable, until I'll done with it Line 112: class DnfProvider(dnf.Base): Line 113: def __init__(self): Line 114: dnf.Base.__init__(self) Line 115: Line 138: help='output file for updates info' Line 139: ) Line 140: parser.add_argument('--packages', '-p', Line 141: dest='packages', Line 142: default=None, it does-> None specifies to unlimit the fetch Line 143: choices=('vdsm', 'libvirt', 'mom'), Line 144: action='append', Line 145: help=( Line 146: 'List of packages names to check.\n' -- To view, visit https://gerrit.ovirt.org/38401 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f6b83e1c18c05142da095b0b537fa6d9aecb59e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches