Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Corrected return value of gluster volume snapshot create ......................................................................
Patch Set 3: (3 comments) https://gerrit.ovirt.org/#/c/39075/3/vdsm.spec.in File vdsm.spec.in: Line 276: Requires > Would this be available in the gluster repo? This change was suggested by Darshan as he has in his patch as well. I think any rpm version which is greater than 3.6.999 (e.g. 3.7) would work with this. https://gerrit.ovirt.org/#/c/39075/3/vdsm/gluster/cli.py File vdsm/gluster/cli.py: Line 1274: find > Is creationtime also returned by gluster? No. Currently we set as current date of engine as creation time. if snapshot is created from CLI it gets as part of sync. https://gerrit.ovirt.org/#/c/39075/3/vdsm/rpc/vdsmapi-gluster-schema.json File vdsm/rpc/vdsmapi-gluster-schema.json: Line 1673: of > update the comment? done -- To view, visit https://gerrit.ovirt.org/39075 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22441d90291be5cb8aa0d5498021b9e9a678adfc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Bala.FA <barum...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Darshan N <dnara...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
