Dan Kenigsberg has posted comments on this change. Change subject: virt: keep libvirt's <driver> element ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/39034/2//COMMIT_MSG Commit Message: Line 6: Line 7: virt: keep libvirt's <driver> element Line 8: Line 9: The issue is that we do not supply the <driver> element when setting up Line 10: a new device. We should keep whatever libvirt has there. > We still won't supply driver even with this patch (since getUnderlying* is The commit message is a bit partial. It should state something like: """ Most commonly, vdsm does not supply the <driver> element to libvirt, so that libvirt is able to apply its logic for setting the correct one (qemu/vhost). Once libvirt has chosen the driver, it must not change. When link state is modified, the chosen driver must be stated explicitly. """ Line 11: Line 12: Change-Id: I043b1c4b932cf0bc83b1f911415245e858ae350d Line 13: Signed-off-by: Petr Horáček <[email protected]> -- To view, visit https://gerrit.ovirt.org/39034 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I043b1c4b932cf0bc83b1f911415245e858ae350d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
