Nir Soffer has posted comments on this change. Change subject: misc: Safer and simpler itmap ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/39119/3/tests/miscTests.py File tests/miscTests.py: Line 213: def dummy(arg): Line 214: raise err Line 215: Line 216: data = [1, 2, 3] Line 217: self.assertEqual(list(misc.itmap(dummy, data, 4)), [err] * len(data)) > Just for the fun of it, I'd add a test with maxthreads = 2 (< len(data)). I will add permutations to test errors with len(data) -1, len(data), len(data) + 1 Line 218: Line 219: Line 220: class RotateFiles(TestCaseBase): Line 221: -- To view, visit https://gerrit.ovirt.org/39119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba6116ac4003702c8e921cebaf494491a6f9afaf Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches