Nir Soffer has posted comments on this change. Change subject: v2v: Convert VM from external source to Data Domain ......................................................................
Patch Set 12: (2 comments) https://gerrit.ovirt.org/#/c/37509/12/tests/v2vTests.py File tests/v2vTests.py: Line 102: Line 103: def disk_copy_stage(self, msg, disk, count): Line 104: self.status_msg = msg Line 105: self.current_disk = disk Line 106: self.disk_count = count We don't use this now - right? Line 107: Line 108: Line 109: class v2vTests(TestCaseBase): Line 110: @MonkeyPatch(libvirtconnection, 'open_connection', hypervisorConnect) Line 132: def testOutputParser(self): Line 133: output = '''[ 0.0] Opening the source -i libvirt -ic vpx://roo... Line 134: [ 1.0] Creating an overlay to protect the source from being modified Line 135: [ 88.0] Copying disk 1/2 to /tmp/v2v/00000002-0002-0002-0002-000000000... Line 136: (0/100%)\r This is incorrect, since when using tripple quoted string in python, you get implicit \n on the end of the line. This may work since your code is reading 1 byte at a time, and will skip the additional \n, but it may also hide an error in the parser, so we should try to use exact test data. Lets change this to use more explicit list format: output = "".join([ "progress line\n", " (0/100%)\r", ... ]) Line 137: (50/100%)\r Line 138: (100/100%)\r Line 139: [ 180.0] Copying disk 2/2 to /tmp/v2v/10000002-0002-0002-0002-000000000... Line 140: (0/100%)\r -- To view, visit https://gerrit.ovirt.org/37509 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
