Petr Horáček has posted comments on this change. Change subject: virt: keep libvirt's <driver> element ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/39034/4/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4506: nic.name = name Line 4507: nic.alias = alias Line 4508: nic.address = address Line 4509: nic.linkActive = linkActive Line 4510: if driver: > x.getElementsByTagName('driver') could report [] when there is no <driver> When i was trying the code, it exploded without this checking, because of there was no <driver> in x. Line 4511: nic.driver = driver Line 4512: # Update vm's conf with address for known nic devices Line 4513: knownDev = False Line 4514: for dev in self.conf['devices']: -- To view, visit https://gerrit.ovirt.org/39034 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I043b1c4b932cf0bc83b1f911415245e858ae350d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
