Piotr Kliczewski has posted comments on this change. Change subject: migration: Use jsonrpc during migration of vms ......................................................................
Patch Set 5: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/36701/5/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 23: from vdsm.utils import traceback Line 24: Line 25: __all__ = ["betterAsyncore", "stompReactor", "stomp"] Line 26: Line 27: CALL_TIMEOUT = 15 Is this related to this change? Line 28: Line 29: _STATE_INCOMING = 1 Line 30: _STATE_OUTGOING = 2 Line 31: _STATE_ONESHOT = 4 https://gerrit.ovirt.org/#/c/36701/5/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 127: self.remoteHost, port = hostPort.rsplit(':', 1) Line 128: Line 129: try: Line 130: client_socket = self._createSocket(port) Line 131: reactor = self._vm.cif.getReactor("stomp") getReactor is in patch https://gerrit.ovirt.org/#/c/38491 which is next patch in this branch. This means that this patch do not compile as it is now. Please rebase. Line 132: self._destServer = jsonrpcvdscli.connect(reactor, client_socket) Line 133: self.log.debug('Initiating connection with destination') Line 134: self._destServer.ping() Line 135: -- To view, visit https://gerrit.ovirt.org/36701 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie38334e6cdcc4d7899bd5e836b3196567fc0bfd8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
