Dan Kenigsberg has submitted this change and it was merged. Change subject: clientIF: stop VmStatsThread on shutdown ......................................................................
clientIF: stop VmStatsThread on shutdown Explicitily stop VmStatsThreads when VDSM is shutting down. This patch makes the flow faster and safer when libvirtd crashes Without this patch, the VmStatsThread exit on shutdown because they find Vm._dom equals None, and they exit with a stacktrace as soon as they woke up for their polling. With this patch, we make things explicit. Relates-To: https://bugzilla.redhat.com/1203210 Change-Id: Id1c01f7a3ea1c22ba0d64b39fb74393e9a52e236 Signed-off-by: Francesco Romani <from...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/39038 Reviewed-by: Michal Skrivanek <michal.skriva...@redhat.com> Reviewed-by: Martin Polednik <mpoled...@redhat.com> Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M vdsm/clientIF.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified Michal Skrivanek: Looks good to me, but someone else must approve Martin Polednik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/39038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1c01f7a3ea1c22ba0d64b39fb74393e9a52e236 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
