Dan Kenigsberg has posted comments on this change. Change subject: Don't prepare image with illegal volumes ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/39302/1/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 3225: if leafUUID not in imgVolumes: Line 3226: raise se.VolumeDoesNotExist(leafUUID) Line 3227: Line 3228: for volUUID in imgVolumes: Line 3229: legality = dom.produceVolume(imgUUID, volUUID).getLegality() we tried hard to avoid single-volume productions like these, as they cause serious performance hit. Could you see if checking legality after image-wide activation is safe enough for this use case? Line 3230: if legality == volume.ILLEGAL_VOL: Line 3231: raise se.prepareIllegalVolumeError(volUUID) Line 3232: Line 3233: imgPath = dom.activateVolumes(imgUUID, imgVolumes) -- To view, visit https://gerrit.ovirt.org/39302 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie543aeb8bdb52305419613ab6297681817124308 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
