Nir Soffer has posted comments on this change. Change subject: v2v: introduction to OutputParser ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/39360/1/vdsm/v2v.py File vdsm/v2v.py: Line 39: ''' Unexpected error while parsing libvirt domain xml ''' Line 40: Line 41: Line 42: class OutputParserError(ValueError): Line 43: ''' Error while parsing virt-v2v output ''' This should inherit from V2VError - please introduce that error in this patch. You want it to inherit from V2VError so you can handle all expected errors in one place. Line 44: Line 45: Line 46: def supported(): Line 47: return not (caps.getos() in (caps.OSName.RHEVH, caps.OSName.RHEL) -- To view, visit https://gerrit.ovirt.org/39360 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54f3d610d704d0b922e38073edcc813cbc27fe83 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
