Ondřej Svoboda has posted comments on this change. Change subject: api: support multiple 'ipv6addrs' per network and deprecate 'ipv6addr' ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/39307/2/vdsm/network/api.py File vdsm/network/api.py: Line 792: netmask="<ipv4>" Line 793: gateway="<ipv4>" Line 794: bootproto="..." Line 795: ipv6addrs=["<ipv6>[/<prefixlen>]", ...] Line 796: ipv6addr="<ipv6>[/<prefixlen>]" (deprecated) > Engine never used the old API, so it can be safely removed. Great – so I don't have to test both APIs :-) To test (in testStaticNetworkConfig) I think I only have to set two addresses instead of one – if the test succeeds on the ifcfg configurator it means that both IPV6ADDR and IPV6ADDR_SECONDARIES worked. I'll update both the schema and the test in the next revision. Line 797: ipv6gateway="<ipv6>" Line 798: ipv6autoconf="0|1" Line 799: dhcpv6="0|1" Line 800: defaultRoute=True|False -- To view, visit https://gerrit.ovirt.org/39307 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d16083781919fe5e5d9c75e9dd4ab744afe45be Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
