Piotr Kliczewski has posted comments on this change. Change subject: xmlrpc: detecting loop on centos7 ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/39343/2/lib/yajsonrpc/betterAsyncore.py File lib/yajsonrpc/betterAsyncore.py: Line 101: return Line 102: Line 103: # we need to check whether there is pending function on Line 104: # our fd because we use eventfds which do not provide it Line 105: if hasattr(self.socket, "pending"): > well, call it xmlprc_detected instead of general name as "recently_detected Done Line 106: while self.socket.pending() > 0 and self.connected: Line 107: self.handle_read() Line 108: Line 109: def recv(self, buffer_size): https://gerrit.ovirt.org/#/c/39343/2/vdsm/protocoldetector.py File vdsm/protocoldetector.py: Line 124: host, Line 125: port Line 126: ) Line 127: detector.handle_dispatcher(dispatcher, (host, port)) Line 128: self._recently_detected = True > you sign it to true on each detection.. how is it tight to xmlrpc? I will modify detector to provide this value. Line 129: break Line 130: else: Line 131: self.log.warning("Unrecognized protocol: %r", data) Line 132: dispatcher.close() -- To view, visit https://gerrit.ovirt.org/39343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I238d10b3bd8aaf8baac55ec81a7d406609e544e6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches