Dan Kenigsberg has submitted this change and it was merged. Change subject: Live Merge: work around racy libvirt pivot ......................................................................
Live Merge: work around racy libvirt pivot Libvirt version 1.2.8-16.el7_1.2 introduced a bug where the synchronous call to blockJobAbort (which we use to pivot to the new leaf after an active layer merge completes) will return before the domain XML has been updated. This makes it look like the pivot failed when it actually succeeded. This means that vdsm state will not be properly synchronized and we may start the vm with a stale volume in the future which will corrupt the VM's storage. See https://bugzilla.redhat.com/show_bug.cgi?id=1202719 for more details. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1206722 Change-Id: I1e794622baf66c75cbe583be03a7b9a4a7e4883d Signed-off-by: Adam Litke <[email protected]> Reviewed-on: https://gerrit.ovirt.org/39303 Reviewed-by: Francesco Romani <[email protected]> Reviewed-by: Allon Mureinik <[email protected]> Reviewed-by: Nir Soffer <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M vdsm/virt/vm.py 1 file changed, 44 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Adam Litke: Verified Dan Kenigsberg: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/39303 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e794622baf66c75cbe583be03a7b9a4a7e4883d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
