Nir Soffer has posted comments on this change. Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool) ......................................................................
Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/38281/11/lib/vdsm/tool/dump_volume_chains.py File lib/vdsm/tool/dump_volume_chains.py: Line 97: dump-volume-chains Line 98: Query VDSM about the existing structure of image volumes and prints Line 99: them in an ordered fashion with optional additional info per volume. Line 100: """ Line 101: parsed_args = _parse_args(args) > Options are for options. We have an argument here which is non-optional (sd What is parsed_args.use_ssl? Looks like an option to me. The canonical name for the parsed program arguments is "options". This is why we have getopt (1) and getopt (3). parse_args convert the uncooked program argument to options object. Line 102: server = _connect_to_server(parsed_args.host, parsed_args.port, Line 103: parsed_args.use_ssl) Line 104: image_chains, volumes_info = _get_volumes_chains( Line 105: server, parsed_args.sd_uuid[0]) -- To view, visit https://gerrit.ovirt.org/38281 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Darshan N <dnara...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Vladik Romanovsky <vladik.romanov...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
