Piotr Kliczewski has uploaded a new change for review. Change subject: xmlrpc: fd leak on centos7 ......................................................................
xmlrpc: fd leak on centos7 We found that when running functional test networkTests we are leaking fds. Each seperate call ends with 1 fd not released. After long investigation I noticed that the leak was caused by not closing plain socket wrapped by ssl socket. Calling shutdown and close on ssl do not closes plain socket. Change-Id: I705b0cf39937fe8d175305ad8ea8ad615f3ffb49 Signed-off-by: pkliczewski <piotr.kliczew...@gmail.com> --- M lib/vdsm/sslutils.py 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/39506/1 diff --git a/lib/vdsm/sslutils.py b/lib/vdsm/sslutils.py index 137a81e..a260fc6 100644 --- a/lib/vdsm/sslutils.py +++ b/lib/vdsm/sslutils.py @@ -53,6 +53,9 @@ def close(self): self.connection.shutdown(socket.SHUT_RDWR) self.connection.close() + # if we do not close socket we get ssl protocol shutdown + # but fd is not released + self.connection.socket.close() def fileno(self): return self.connection.fileno() -- To view, visit https://gerrit.ovirt.org/39506 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I705b0cf39937fe8d175305ad8ea8ad615f3ffb49 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches