Piotr Kliczewski has posted comments on this change. Change subject: tests: making sure that after events changes all tests passes ......................................................................
Patch Set 5: (5 comments) https://gerrit.ovirt.org/#/c/39031/5/tests/protocoldetectorTests.py File tests/protocoldetectorTests.py: Line 69: t.start() Line 70: Line 71: def close(self): Line 72: if self.dispatcher is not None: Line 73: self.dispatcher.close() > Why do we care about closing dispatcher? we just removed it from event loop My aim here is to get rid of stack traces when the tests are done. If any of the tests fails there is bunch of stack traces printed to the console. If all are OK we do not see them. Line 74: Line 75: Line 76: class Echo(Detector): Line 77: """ A detector echoing sent line """ Line 111: def tearDown(self): Line 112: if self.acceptor: Line 113: self.acceptor.stop() Line 114: for detector in self.detectors: Line 115: detector.close() > Why do we care about closing detectors? As above. Line 116: Line 117: # Testing Line 118: Line 119: def test_reject_ssl_accept_error(self): https://gerrit.ovirt.org/#/c/39031/5/tests/scheduleTests.py File tests/scheduleTests.py: Line 93 Line 94 Line 95 Line 96 Line 97 > This tests were never broken - I wonder why commit 1db6e0419d6af marking th I have seen it many times that on slower machines this test always failed. Line 98: def test_cancel_call_many(self, clock): Line 99: self.create_scheduler(clock) Line 100: # we do not care for this test Line 101: # on slower machines tasks can be run Line 102: delay = 10 > Why delay of 0.3 is too small? 10 seconds delay seems way too much. Looks l Response is on previous version tab Line 103: tasks = [] Line 104: for i in range(self.MAX_TASKS): Line 105: task = Task(clock) Line 106: call = self.scheduler.schedule(delay, task) Line 126: def test_stop_scheduler_many(self, clock): Line 127: self.create_scheduler(clock) Line 128: # we do not care for this test Line 129: # on slower machines tasks can be run Line 130: delay = 10 > Same Response is on previous version tab Line 131: tasks = [] Line 132: for i in range(self.MAX_TASKS): Line 133: task = Task(clock) Line 134: call = self.scheduler.schedule(delay, task) -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
