Nir Soffer has posted comments on this change.

Change subject: v2v: make sure not virt-v2v processes leftovers
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/37938/1/vdsm/v2v.py
File vdsm/v2v.py:

Line 117:     else:
Line 118:         with _lock:
Line 119:             del _jobs[jobId]
Line 120:             if _jobs:
Line 121:                 kill_zombie_jobs()
We don't need this, when ImportVM thread dies, the virt-v2v process it started 
gets a SIGKILL.
Line 122:     return {'status': doneCode, 'ovf': ovf}
Line 123: 
Line 124: 
Line 125: def kill_zombie_jobs():


-- 
To view, visit https://gerrit.ovirt.org/37938
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4788fdc57bae4047b2f83bcb56b790df58c46814
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to