Martin Sivák has posted comments on this change. Change subject: Cache the result of numaUtils.getVcpuPids ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/38564/3/vdsm/numaUtils.py File vdsm/numaUtils.py: Line 47: path = _libvirt_xml_path(vmName) Line 48: mtime = os.path.getmtime(path) Line 49: Line 50: if path in _libvirt_vcpu_pids_cache: Line 51: lastmtime, value = _libvirt_vcpu_pids_cache[path] > ...so this raise some suspects Indeed, but aren't we stopping the stats threads before we cleanup a VM? Additional exception handling should solve this, I would like to avoid locks here. Line 52: if lastmtime == mtime: Line 53: return value Line 54: Line 55: runInfo = ET.parse(path) -- To view, visit https://gerrit.ovirt.org/38564 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I135143bccdd29697ec673819212193c0fc217e56 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
