Michal Skrivanek has posted comments on this change. Change subject: vm: hyperv: support all the libvirt optimizations ......................................................................
Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/29234/12/vdsm/virt/vmxml.py File vdsm/virt/vmxml.py: Line 190: else: Line 191: clockName = 'rtc' Line 192: Line 193: # 'hypervclock' does not support the 'track' attribute. Line 194: # libvirt docs is not very clear here. > are* :) Also, where did the track attribute go then? This is clearly correc yeah, taht was my bad wording Francesco. I'm concerned that for RTC the "track" disappears Line 195: m = Element('clock', offset='variable', Line 196: adjustment=str(self.conf.get('timeOffset', 0))) Line 197: m.appendChildWithArgs('timer', name=clockName, tickpolicy='catchup') Line 198: m.appendChildWithArgs('timer', name='pit', tickpolicy='delay') -- To view, visit https://gerrit.ovirt.org/29234 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia10cb4ce254b6e6f560c045aff9e68846fe4771f Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
