Michal Skrivanek has posted comments on this change. Change subject: vm: hyperv: support more libvirt optimizations ......................................................................
Patch Set 13: Code-Review+1 (1 comment) suggesting split of spec changes https://gerrit.ovirt.org/#/c/29234/13/vdsm.spec.in File vdsm.spec.in: Line 278: %endif Line 279: Line 280: %if 0%{?rhel} Line 281: %if 0%{?rhel} >= 7 Line 282: Requires: qemu-kvm%{?rhev_suffix} >= 1.5.3-60.el7 I think this deserves a separate changeset. Currently it's quite a mess. We should no longer depend on qemu-kvm(no -rhev) anywhere. It's not going to work, we supply it in our repo. There are major version differences between base RHEL 7 and qemu we need to use Line 283: Requires: qemu-img%{?rhev_suffix} >= 1.5.3-60.el7 Line 284: %else Line 285: Requires: qemu-kvm%{?rhev_suffix} >= 2:0.12.1.2-2.422 Line 286: Requires: qemu-img%{?rhev_suffix} >= 2:0.12.1.2-2.422 -- To view, visit https://gerrit.ovirt.org/29234 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia10cb4ce254b6e6f560c045aff9e68846fe4771f Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
