Shahar Havivi has posted comments on this change. Change subject: v2v: cleanup v2v directory leftovers ......................................................................
Patch Set 4: (3 comments) https://gerrit.ovirt.org/#/c/39789/4/vdsm/v2v.py File vdsm/v2v.py: Line 216: def clean_leftovers(): Line 217: logging.debug('Cleaning v2v leftovers') Line 218: for ovf in glob.glob('%s/*.ovf' % _V2V_DIR): Line 219: try: Line 220: logging.info('Removing ovf file %s', ovf) > Use %r for the path Done Line 221: os.remove(ovf) Line 222: except Exception as e: Line 223: logging.error('Cannot remove file: %s, err: %s', ovf, e) Line 224: Line 223: logging.error('Cannot remove file: %s, err: %s', ovf, e) Line 224: Line 225: for tmp in glob.glob('%s/*.tmp' % _V2V_DIR): Line 226: try: Line 227: logging.warn('Removing tmp file %s', tmp) > - Use %r for the path Done Line 228: os.remove(tmp) Line 229: except Exception as e: Line 230: logging.error('Cannot remove file: %s, err: %s', tmp, e) Line 231: Line 226: try: Line 227: logging.warn('Removing tmp file %s', tmp) Line 228: os.remove(tmp) Line 229: except Exception as e: Line 230: logging.error('Cannot remove file: %s, err: %s', tmp, e) > Use %r for paths: Done Line 231: Line 232: Line 233: def _read_ovf(job_id): Line 234: file_name = os.path.join(_V2V_DIR, "%s.ovf" % job_id) -- To view, visit https://gerrit.ovirt.org/39789 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2f5b63863f4f7dc85d6af0ca015099274715441 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
