Dan Kenigsberg has posted comments on this change. Change subject: Get list of nameservers for host ......................................................................
Patch Set 3: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/39460/3/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 84: OPERSTATE_UP = 'up' Line 85: DUMMY_BRIDGE # Appease flake8 since dummy bridge should be exported from here Line 86: Line 87: Line 88: def get_host_nameservers(): please expose this in a the get() function of this module. this can happen in a follow-up patch, where you should also update vdsm/rpc/vdsmapi-schema.json with the new return type of getVdsCapabilities. Line 89: """Returns a list of nameservers listed in /etc/resolv.conf""" Line 90: with open(DNS_RESOLVE_CONF_FILE,'r') as file_object: Line 91: file_text = file_object.read() Line 92: return _parse_dnss(file_text) Line 86: Line 87: Line 88: def get_host_nameservers(): Line 89: """Returns a list of nameservers listed in /etc/resolv.conf""" Line 90: with open(DNS_RESOLVE_CONF_FILE,'r') as file_object: please fix pep8 errors - in particular, place a space after commas. Line 91: file_text = file_object.read() Line 92: return _parse_dnss(file_text) Line 93: Line 94: -- To view, visit https://gerrit.ovirt.org/39460 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ce8a0e2bf93b118620739b144e70c576f03cd08 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Priya Avhad <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Priya Avhad <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
