Francesco Romani has posted comments on this change. Change subject: Added support for iothreads ......................................................................
Patch Set 4: (1 comment) let's split this patch in two: - this patch should just pass through numOfIoThreads and pinToThread received by Engine (the latter should added to specParams and documented in schema), with maybe validation of both fields but no policy/assignment - a followup patch will add the existing round-robin algo to pin disks to threads. On this patch we will discuss (with other reviewers as well) if we want this algo here in VDSM or not. https://gerrit.ovirt.org/#/c/39796/4/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 831: """ Line 832: if 'numOfIoThreads' in self.conf and 'index' in drv\ Line 833: and drv['type'] == 'disk' and drv['iface'] == 'virtio': Line 834: drv['pinToIoThread'] = int(drv['index']) \ Line 835: % self.conf['numOfIoThreads'] + 1 I came to think only now that this, albeit very simple, is policy and we usually keep policy in Engine, not in VDSM. Engine may want to handle the pinning in a different way, for example: - have a VM with two iothreads - pin a disk alone to one iothread (maybe that disk will run a database of some kind) - pin everything else to other iothread Line 836: Line 837: def __legacyDrives(self): Line 838: """ Line 839: Backward compatibility for qa scripts that specify direct paths. -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
