Francesco Romani has posted comments on this change. Change subject: stomp: Make sure the \0 is a last char in the buffer ......................................................................
Patch Set 14: (1 comment) https://gerrit.ovirt.org/#/c/35938/14/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py: Line 252: ndata = len(buf) Line 253: if ndata < (cl + 1): Line 254: return False Line 255: Line 256: if buf[cl] != "\0": > We could use endswith as well. Will update. It is not terribly important, but could be clearer _and_ faster. Your call, mine was a question, not a request. Line 257: raise RuntimeError("Frame end is missing \\0") Line 258: Line 259: remainingBytes = 0 Line 260: self._flush() -- To view, visit https://gerrit.ovirt.org/35938 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0d8eaae161f3ec6c77726f4f9da044ab7c629d4 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
