Adam Litke has submitted this change and it was merged.

Change subject: virt: Continue to collect extend candidates after errors
......................................................................


virt: Continue to collect extend candidates after errors

Previously, if we had one bad drive that libvirt fail to get watermarks,
we would stop collecting extend candidates and log a traceback. This
would cause a vm to pause, since we may never extend any of its disks,
and the log would be littered with unhelpful tracebacks.

Now we log an error in such case and continue to collect extend
candidates, so error with one disk cannot effect other disks.

Change-Id: I5d321001d096c45f5b78982c3c0f225728bd4184
Signed-off-by: Nir Soffer <[email protected]>
Reviewed-on: https://gerrit.ovirt.org/38045
Reviewed-by: Adam Litke <[email protected]>
---
M vdsm/virt/vm.py
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
  Nir Soffer: Verified
  Adam Litke: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/38045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5d321001d096c45f5b78982c3c0f225728bd4184
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Ala Hino <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Candace Sheremeta <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to