Dan Kenigsberg has submitted this change and it was merged. Change subject: protocoldetecor: fd leak fix ......................................................................
protocoldetecor: fd leak fix When running networkTests (xmlrpc) we noticed that each connection to vdsm leaks a fd. After the investigation we noticed that even that SSLSocket is closed the fd was not released. M2C releases fd by calling raw socket.close() in __del__ method. This means that there is somewhere referece kept to a socket object. After further investigation it was clear that socket reference is hold by Dispatcher object. There was an issue when we create new dispatcher and not pass map param socket_map is used instead. socket_map is never updated after initial creating which creates ref leak. Change-Id: I705b0cf39937fe8d175305ad8ea8ad615f3ffb49 Signed-off-by: pkliczewski <[email protected]> Reviewed-on: https://gerrit.ovirt.org/39506 Reviewed-by: Dan Kenigsberg <[email protected]> Reviewed-by: Francesco Romani <[email protected]> Reviewed-by: Nir Soffer <[email protected]> --- M lib/yajsonrpc/betterAsyncore.py M vdsm/protocoldetector.py 2 files changed, 10 insertions(+), 34 deletions(-) Approvals: Piotr Kliczewski: Verified Nir Soffer: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/39506 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I705b0cf39937fe8d175305ad8ea8ad615f3ffb49 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
