Dan Kenigsberg has submitted this change and it was merged.

Change subject: stomp: Stomp encoder\decoder improvements
......................................................................


stomp: Stomp encoder\decoder improvements

We need to make sure to escape special characters during encoding and
decoding. During encoding, use more efficient string join instead of
string concatenation due to its speed.

Change-Id: I341e46463e654ae0a086cd49af18aa336b86cb6e
Signed-off-by: Saggi Mizrahi <[email protected]>
Signed-off-by: pkliczewski <[email protected]>
Reviewed-on: https://gerrit.ovirt.org/35255
Reviewed-by: Yaniv Bronhaim <[email protected]>
Reviewed-by: Francesco Romani <[email protected]>
Reviewed-by: Dan Kenigsberg <[email protected]>
---
M lib/yajsonrpc/stomp.py
M tests/Makefile.am
A tests/encodingTests.py
3 files changed, 74 insertions(+), 22 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/35255
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I341e46463e654ae0a086cd49af18aa336b86cb6e
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Dima Kuznetsov <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to