Shahar Havivi has posted comments on this change. Change subject: v2v: Convert VM from external source to Data Domain ......................................................................
Patch Set 25: (4 comments) https://gerrit.ovirt.org/#/c/37509/25/vdsm/API.py File vdsm/API.py: Line 1404: network: type, macAddr, bridge, dev Line 1405: """ Line 1406: return v2v.get_external_vms(uri, username, password) Line 1407: Line 1408: def convertExternalVm(self, uri, username, password, vmProperties, jobId): > You must do the vmProperties -> vmInfo rename in all the files. See http:// I will change all to vminfo, btw why didn't I got that error locally I am with F20 as well... Line 1409: return v2v.convert_external_vm(uri, username, password, vmProperties, Line 1410: jobId, self._cif.irs) Line 1411: Line 1412: # Networking-related functions https://gerrit.ovirt.org/#/c/37509/25/vdsm/rpc/BindingXMLRPC.py File vdsm/rpc/BindingXMLRPC.py: Line 366: Line 367: def convertExternalVm(self, uri, username, password, vmProperties, jobId): Line 368: api = API.Global() Line 369: return api.convertExternalVm(uri, username, password, vmProperties, Line 370: jobId) > Please update vmProperties -> vmInfo in all files. Consistency is important Done Line 371: Line 372: def vmPause(self, vmId): Line 373: vm = API.VM(vmId) Line 374: return vm.pause() https://gerrit.ovirt.org/#/c/37509/25/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 3813: # @password: libvirt connection password Line 3814: # Line 3815: # @vminfo: information of the VM such as name, id etc Line 3816: # Line 3817: # @jobId: Assign a UUID to this operation which can be used > Previously you had 3 lowercase parameters, and 2 mixedCase. Now that you ar I will change in api and biding as well Line 3818: # to identify it in @HostStats Line 3819: # Line 3820: # Since: 4.17.0 Line 3821: ## https://gerrit.ovirt.org/#/c/37509/25/vdsm/v2v.py File vdsm/v2v.py: Line 339: self._proc.kill() Line 340: except OSError as e: Line 341: if e.errno != errno.ESRCH: Line 342: logging.debug('Job %r virt-v2v process not running', Line 343: self._id) > Here the error is *not* ESRCH, which means that process exists but you cann in this case it should be: try: self._proc.kill() logging.debug('Job %r virt-v2v process was killed', self._id) except OSError as e: if e.errno != errno.ESRCH: raise else: logging.debug('Job %r virt-v2v process not running', self._id) finally: zombiereaper.autoReapPID(self._proc.pid) Line 344: raise Line 345: else: Line 346: logging.debug('Job %r virt-v2v process was killed', Line 347: self._id) -- To view, visit https://gerrit.ovirt.org/37509 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
