Ondřej Svoboda has posted comments on this change. Change subject: dnsmasqDhcp does not need to consider el6 anymore ......................................................................
Patch Set 2: Code-Review-1 (2 comments) There is no need for variables to carry constant values. https://gerrit.ovirt.org/#/c/39536/2/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 110: """ You can move the triple quotes to the end of the first line :-) Line 115: dhcpv6_range_from, dhcpv6_range_to Please just use the constants here. -- To view, visit https://gerrit.ovirt.org/39536 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb55bb609ca0ca60ce005257a5335d0a150f53d6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches