Dan Kenigsberg has posted comments on this change. Change subject: disconnecting a port from a bridge should not consider el6 anymore ......................................................................
Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/39544/2/vdsm/network/api.py File vdsm/network/api.py: Line 433: network) Line 434: Line 435: Line 436: def _disconnect_bridge_port(port): Line 437: ipwrapper.linkSet(port, ['nomaster']) could you please include in this patch a hard requirement of an el7-grade iproute2 in the spec? I'd like to avoid installing of vdsm on hosts without it. Line 438: Line 439: Line 440: @_alterRunningConfig Line 441: def _delNetwork(network, vlan=None, bonding=None, nics=None, force=False, -- To view, visit https://gerrit.ovirt.org/39544 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e126b4986d81d8b3bb831f7d6145cde83645d2a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
