Martin Polednik has posted comments on this change. Change subject: virt: support per-vm stats age ......................................................................
Patch Set 33: Code-Review+1 (1 comment) Very little stylistic issue with comments vs docstrings but still way better. +1ing the code itself because I have very little experience with our sampling code and cannot comment further on the functionality https://gerrit.ovirt.org/#/c/38066/33/vdsm/virt/sampling.py File vdsm/virt/sampling.py: Line 479: # So, under the assumption that at stable state stats collection has Line 480: # a time cost negligible with respect the collection interval, we need Line 481: # to take the sample timestamp BEFORE to start the possibly-blocking call. Line 482: # If we take the timestamp after the call, we have no means to distinguish Line 483: # between a well behaving call and an unblocked stuck call. I'd say move to class docstring Line 484: Line 485: def clock(self): Line 486: """ Line 487: Provide timestamp compatible with what put() expects -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
